update PDK template and workflows#1629
Uh oh!
There was an error while loading. Please reload this page.
Conversation
h0tw1r3force-pushed the pdk branch 2 times, most recently from 29da24a to 72fd570Compare* remove the x86_64 binaries that should not have been added to the repo * mysql_login_path is not supported by MariaDB so skip related tests if the test host doesn't have the binary.
h0tw1r3force-pushed the pdk branch 2 times, most recently from 3ee5a50 to 3aae838Compareh0tw1r3force-pushed the pdk branch 6 times, most recently from 915caa1 to 7c6c0c8Compare
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Ramesh7 left a comment
Ramesh7 left a comment There was a problem hiding this comment.
Reviewed the changes and looks good to me except minor cosmetic comments.
@bastelfreak@smortex can you please also have quick look?
smortex left a comment
smortex left a comment There was a problem hiding this comment.
Looks good overall. I added inline comments for 2 tiny things that we may want to think about adjusting.
Uh oh!
There was an error while loading. Please reload this page.
spec/classes/mysql_params_spec.rb Outdated
| context"on #{os}"do | ||
| let(:facts){facts} | ||
| it{is_expected.tocompile} |
There was a problem hiding this comment.
I would expect a private class to not compile 😄 (the commit message of this change is about tests and private classes)
It happen that the class is marked as private in the API but does not call assert_private()… Do we want to make sure private classes are not directly call and add assert_private() to all classes with @api private? (I would say yes, as far as I am concerned, but have not checked if this can cause trouble).
There was a problem hiding this comment.
I would expect a private class to not compile 😄 (the commit message of this change is about tests and private classes)
Removed
It happen that the class is marked as private in the API but does not call assert_private()… Do we want to make sure private classes are not directly call and add assert_private() to all classes with @api private? (I would say yes, as far as I am concerned, but have not checked if this can cause trouble).
Makes sense to me, but this change is intended to be maintenance only, with no potentially breaking changes.
I'll open another PR for that.
h0tw1r3force-pushed the pdk branch 2 times, most recently from 9e28543 to 10fd765Compare
h0tw1r3 commented Jun 24, 2024
@Ramesh7 addressed issues, can you review and merge please? |
3 participants
Uh oh!
There was an error while loading. Please reload this page.