Do not call str.splitlines() twice in the same function.#628
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
krassowski approved these changes Apr 3, 2025
Member
krassowski left a comment
krassowski left a comment There was a problem hiding this comment.
LGTM, also takes away a worry about accidentally getting the index wrong.
krassowski changed the title str.splitlines() twice in the same function.krassowski merged commit 04fa3e5 into python-lsp:develop 10 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The better solution might be to have a proper text editing framework, but since the code itself in workspace.py is very simple I'm proposing just this simple solution.