Skip to content

Conversation

@Conengmo
Copy link
Member

@ConengmoConengmo commented Mar 16, 2025

While developing I struggled with the autofix PR's from Pre-commit. It lead to merge conflicts on every push and much frustration. I think it's better to disable it.

I had an other issue also, where Flake8 and Black were disagreeing on a style aspect. Flake8 should ignore two aspects that Black enforces. We may switch to Ruff in the future, but for now just ignore them.

These changes are needed to merge #193.

@ocefpaf
Copy link
Member

Yeah, we should not use autofix. That was probably a copy-n-pasta from when I added the config file.

@Conengmo
Copy link
MemberAuthor

Conengmo commented Mar 16, 2025

I reckon they switched the default on their side, because it didn’t use to be an issue.

thanks for the review btw!

@ConengmoConengmo merged commit b14652b into python-visualization:mainMar 16, 2025
10 checks passed
@ConengmoConengmo deleted the precommit-update branch March 16, 2025 17:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Conengmo@ocefpaf