Fix javascript template#2071
Merged
Fix javascript template #2071
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Conengmo approved these changes Jan 4, 2025
Member
Conengmo left a comment
Conengmo left a comment There was a problem hiding this comment.
Good catch! Thanks for looking into this.
Man we really need better tests...
CollaboratorAuthor
hansthen commented Jan 4, 2025
Let's make that our number one goal for 2025 to improve our test coverage. |
hansthen merged commit 29062dd into python-visualization:main 11 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Conengmo pushed a commit that referenced this pull request Jan 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One too many semi-colons. Closes#2070.