Move blurb test subcommand into test suite#37
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ezio-melotti approved these changes Nov 11, 2024
hugovk changed the title blurb test subcommand into test suiteSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, there's a
blurb testcommand which checks the files in https://github.com/python/blurb/tree/main/tests/fail and https://github.com/python/blurb/tree/main/tests/pass are dealt with as expected.They're not run as part of the regular unit test suite and aren't part of test coverage.
This PR moves them into the test suite and removes the
blurb testsubcommand.As an alternative, we could possibly keep the
blurb testsubcommand and also make then runnable via the test suite, but I think it might be cleaner to have them all in one place?