Implement storing runtime state in repo level Git config

[webknjaz]

Ref #277

[webknjaz]

@Mariatta@abadger I've cleaned things up a bit. Maybe it's time to move helper functions into util module/package or is it a task for separate PR?

[webknjaz]

Hi @Mariatta,

I'm currently waiting for your approval wrt architectural changes. After that I'll proceed with adjusting/adding tests.

P.S. @abadger suggested that I could add a CLI command for git config --local --remove-section cherry-picker but I'm doubtful: it's a dangerous thing for the flow and providing users with such UI might encourage them to overuse it where they don't understand consequences. Ideally, that failure shouldn't be happening during the normal process at all.

[Mariatta]

Sorry for the delay. Will take a look in the weekend.

[webknjaz]

Cool, thanks :)

[webknjaz]

Hey @Mariatta, any 🤔💭 on this so far?

[webknjaz]

Hi @Mariatta, any comments?

[Mariatta]

So sorry, I think I'm not able to effectively review this PR.
Is there anyone else who might be able to help review this?

[webknjaz]

@Mariatta
Well, @abadger said that it's fine. We just wanted to check that it's fine with you since you're the maintainer.

[webknjaz]

I'll ask @asvetlov to take a look as well, then, to have more eyes on it.

[asvetlov]

The idea looks interesting.
Would you add tests for it?
At least we have several ones in test.py already.

[webknjaz]

Thanks for the review, Andrew! I just wanted to wait for architectural approval before investing some time into tests. Now I can proceed :)

[Mariatta]

Thanks @webknjaz and @asvetlov. For me, as long as there is no change to how it works for CPython /miss-islington’s purpose, then I'm good with it.

[webknjaz]

Great, thanks @Mariatta!

[webknjaz]

Update: with the recent commits I've hit 83% test coverage.

[webknjaz]

@Mariatta@abadger@asvetlov I believe this is ready for the final review :)

[Mariatta]

It seems ok to me. Would @abadger or @asvetlov be able to do more thorough review?

[webknjaz]

Thanks. I'll ping them. I think Andrew is away for a couple of days, though...

[asvetlov]

LGTM now

[Mariatta]

Thanks @asvetlov and @webknjaz. If you could update the release notes and up the version, I can merge and get it deployed to PyPI.

[webknjaz]

Sure, on it

[webknjaz]

done!

[Mariatta]

Thanks! Will release soon!