webbrowser.py update to use argparse.py

[HasanDiwan]

BPO	24395
Nosy	@birkenfeld, @berkerpeksag
Files	webbrowser.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2015-06-06.15:22:59.767>
labels = ['type-feature', 'library']
title = 'webbrowser.py update to use argparse.py'
updated_at = <Date 2019-03-15.22:00:55.953>
user = 'https://bugs.python.org/HasanDiwan'

bugs.python.org fields:

activity = <Date 2019-03-15.22:00:55.953>
actor = 'BreamoreBoy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2015-06-06.15:22:59.767>
creator = 'Hasan Diwan'
dependencies = []
files = ['39641']
hgrepos = []
issue_num = 24395
keywords = []
message_count = 3.0
messages = ['244913', '244915', '244918']
nosy_count = 3.0
nosy_names = ['georg.brandl', 'berker.peksag', 'Hasan Diwan']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue24395'
versions = ['Python 3.6']

Linked PRs

• gh-68583: webbrowser: replace getopt with argparse, add long options #117047

[HasanDiwan]

The webbrowser module uses getopt, which needs to be ripped out and replaced with argparse. The attached file does just this.

[berkerpeksag]

Thanks!

A few comments:

• New features like this can only go into Python 3.6 (the "default" branch)
• The CLI is partially tested (see Lib/test/test_webbrowser.py). You'll need to add additional tests (e.g. add tests for the -t and -h options)
• It would be nice if you could send your changes in a patch format. Please see https://docs.python.org/devguide/patch.html for more information

[BreamoreBoy]

This strikes me as pointless code churn.

[CAM-Gerlach]

Just to confirm, getopt is still used in webbrowser as of the beginning of the Python 3.13 cycle. Replacing it with argparse would improve usability, reduce manual argument parsing code and avoid the use of a legacy module, per #105735

[hugovk]

Please see PR #117047.