PyInstanceMethod_Type isn't hashable

[wolever]

BPO	28842
Nosy	@wolever, @MojoVampire

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2016-11-30.18:26:33.954>
labels = ['interpreter-core', 'type-feature', '3.11']
title = "PyInstanceMethod_Type isn't hashable"
updated_at = <Date 2021-11-30.16:58:14.601>
user = 'https://github.com/wolever'

bugs.python.org fields:

activity = <Date 2021-11-30.16:58:14.601>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2016-11-30.18:26:33.954>
creator = 'wolever'
dependencies = []
files = []
hgrepos = []
issue_num = 28842
keywords = []
message_count = 2.0
messages = ['282091', '282094']
nosy_count = 2.0
nosy_names = ['wolever', 'josh.r']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue28842'
versions = ['Python 3.11']

[wolever]

The PyInstanceMethod_Type, unlike all other method types, isn't hashable.

It seems like the code exists, it's just been commented out: https://github.com/python/cpython/blame/c30098c8c6014f3340a369a31df9c74bdbacc269/Objects/classobject.c#L569

This came up here: wolever/pprintpp#18

And Christian Heimes doesn't remember why it was commented out: https://twitter.com/ChristianHeimes/status/803900655324790784

[MojoVampire]

Note: It's a little strange that instancemethod as a type sticks around even though literally nothing in Python uses it. Is there some reason we kept it in the 3.x transition? Extension types are using it, so I guess we can't drop it now, but I'm trying to figure out why it was kept around, allowing the extensions to develop dependencies on it.

[hugovk]

It seems like the code exists, it's just been commented out: c30098c/Objects/classobject.c#L569 (blame)

The commented instancemethod_hash was removed in #31814.