PyImport_Cleanup is called with builtins_copy == NULL in test_embed

[serhiy-storchaka]

BPO	33379
Nosy	@brettcannon, @ncoghlan, @ericsnowcurrently, @serhiy-storchaka

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2018-04-28.22:03:00.332>
labels = ['interpreter-core', '3.8', 'type-bug', '3.7']
title = 'PyImport_Cleanup is called with builtins_copy == NULL in test_embed'
updated_at = <Date 2018-04-29.05:56:26.461>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2018-04-29.05:56:26.461>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2018-04-28.22:03:00.332>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 33379
keywords = []
message_count = 2.0
messages = ['315868', '315881']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'ncoghlan', 'eric.snow', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33379'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[serhiy-storchaka]

PyImport_Cleanup is called with builtins_copy == NULL in run_embedded_interpreter() in Lib/test/test_embed.py. This error was silenced by calling PyErr_Clear(), but it still looks as error to me. It was exposed by PR 6606.

[serhiy-storchaka]

PyImport_Cleanup() is called in Py_EndInterpreter(), but Py_NewInterpreter() doesn't call _PyImport_Init() which initializes builtins_copy.

[iritkatriel]

PyImport_Cleanup was renamed to finalize_modules in:

commit dff1ad5 (HEAD, refs/bisect/bad)
Author: Victor Stinner vstinner@python.org
Date: Fri Oct 30 18:03:28 2020 +0100

bpo-42208: Move _PyImport_Cleanup() to pylifecycle.c (GH-23040)

Move _PyImport_Cleanup() to pylifecycle.c, rename it to
finalize_modules(), split it (200 lines) into many smaller
sub-functions and cleanup the code.