Missing terminated NUL in the length of sockaddr_un

[zonyitoo]

BPO	44493
Nosy	@gpshead, @pitrou, @tiran, @serhiy-storchaka, @miss-islington, @zonyitoo
PRs	bpo-44493: Add missing terminated NUL in sockaddr_un's length #26866 [3.10] bpo-44493: Add missing terminated NUL in sockaddr_un's length (GH-26866) #32140 [3.9] bpo-44493: Add missing terminated NUL in sockaddr_un's length (GH-26866) #32141 [3.9] [3.10] bpo-44493: Add missing terminated NUL in sockaddr_un's length (GH-26866) (GH-32140) #32156

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gpshead'
closed_at = <Date 2022-03-28.01:58:49.361>
created_at = <Date 2021-06-23.03:08:23.197>
labels = ['extension-modules', '3.11', '3.9', '3.10', 'performance']
title = 'Missing terminated NUL in the length of sockaddr_un'
updated_at = <Date 2022-03-28.23:52:51.525>
user = 'https://github.com/zonyitoo'

bugs.python.org fields:

activity = <Date 2022-03-28.23:52:51.525>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2022-03-28.01:58:49.361>
closer = 'zonyitoo'
components = ['Extension Modules']
creation = <Date 2021-06-23.03:08:23.197>
creator = 'zonyitoo'
dependencies = []
files = []
hgrepos = []
issue_num = 44493
keywords = ['patch']
message_count = 18.0
messages = ['396379', '398213', '400058', '415916', '415943', '415944', '415945', '415947', '415949', '415950', '415953', '415956', '415966', '415967', '415988', '416135', '416200', '416207']
nosy_count = 7.0
nosy_names = ['gregory.p.smith', 'pitrou', 'christian.heimes', 'habnabit', 'serhiy.storchaka', 'miss-islington', 'zonyitoo']
pr_nums = ['26866', '32140', '32141', '32156']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue44493'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[zonyitoo]

https://github.com/python/cpython/blob/main/Modules/socketmodule.c#L1700

[zonyitoo]

Changes have been made in this PR, waiting for reviewing.

[zonyitoo]

Hello and PING.

[habnabit]

sigh.. adding myself to nosy here too in the hope that this gets any traction

[zonyitoo]

I think I have already provided enough information about this bug.

The len_ret was the length of sockaddr_un, which should include the terminated NUL in the sun_path. But the original implementation only use path.len + offsetof(struct sockaddr_un, sun_path).

References:

1. https://man7.org/linux/man-pages/man7/unix.7.html The Address format section.

2. The SUN_LEN macro in *BSD systems, https://man.cx/unix(4)

[zonyitoo]

Ping Heimes.

This is a huge bug that exists for a very long time, please consider merge it and fix it in the next relesae.

[tiran]

Antoine, Serhiy, please take a look. You are the last developers that touched the AF_UNIX socket path code.

Ty, why are you pinging me on this issue or on the PR? I'm neither familiar with that code nor responsible for it.