Skip to content

gh-81057: Move Threading-Related Globals to _PyRuntimeState#100084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericsnowcurrently merged 8 commits into from
Dec 9, 2022
Merged

gh-81057: Move Threading-Related Globals to _PyRuntimeState #100084

ericsnowcurrently merged 8 commits into from
Dec 9, 2022

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commented Dec 7, 2022•
edited by bedevere-bot
Loading

@ericsnowcurrentlyericsnowcurrently requested a review from a team as a code ownerDecember 7, 2022 17:17
@netlify
Copy link

netlifybot commented Dec 7, 2022•
edited
Loading

✅ Deploy Preview for python-cpython-preview ready!

NameLink
🔨 Latest commit3c22543
🔍 Latest deploy loghttps://app.netlify.com/sites/python-cpython-preview/deploys/6392802b0234d300086d75f9
😎 Deploy Previewhttps://deploy-preview-100084--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bedevere-botbedevere-bot mentioned this pull request Dec 7, 2022
Closed
@ericsnowcurrentlyericsnowcurrently removed the request for review from a teamDecember 7, 2022 17:17
@ericsnowcurrentlyericsnowcurrentlyforce-pushed the consolidate-threading-globals branch from f2399f9 to f05396bCompareDecember 8, 2022 01:34
@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Dec 8, 2022

How about changing the thread initializer PyThread_init_thread to be always called on startup? It will eliminate these globals altogether be threadsafe so will help in per interpreter GIL too.

@ericsnowcurrently
Copy link
MemberAuthor

ericsnowcurrently commented Dec 8, 2022•
edited
Loading

It's called when the GIL is created, which is already a part of initializing the main interpreter. Perhaps I misunderstood what you meant?

@ericsnowcurrentlyericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2022
@bedevere-bot
Copy link

bedevere-bot commented Dec 8, 2022

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit f05396b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2022
@ericsnowcurrentlyericsnowcurrentlyforce-pushed the consolidate-threading-globals branch from f05396b to 3c22543CompareDecember 9, 2022 00:24
@ericsnowcurrentlyericsnowcurrently merged commit 1160001 into python:mainDec 9, 2022
@ericsnowcurrentlyericsnowcurrently deleted the consolidate-threading-globals branch December 9, 2022 00:51
@vstinner
Copy link
Member

vstinner commented Dec 9, 2022

This change broke the wasm32-wasi 3.x buildbot: https://buildbot.python.org/all/#/builders/1046/builds/1051

@ericsnowcurrently
Copy link
MemberAuthor

ericsnowcurrently commented Dec 9, 2022

I'll look into it.

@ericsnowcurrentlyericsnowcurrently mentioned this pull request Dec 9, 2022
Merged
ericsnowcurrently added a commit that referenced this pull request Dec 9, 2022
@ericsnowcurrently
gh-81057: Fix the wasm32-wasi Buildbot (gh-100139)
8d0bd93
The build was broken by gh-100084. #81057
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently@kumaraditya303@bedevere-bot@vstinner