Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-94172: Update docs for params removed in 3.12#100431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94172: Update docs for params removed in 3.12 #100431
Uh oh!
There was an error while loading. Please reload this page.
Conversation
hugovk commented Dec 22, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
6f55419 to 770bc01Compare
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating these! It looks like the remaining arguments were also made keyword-only.
bedevere-bot commented Dec 22, 2022
When you're done making the requested changes, leave the comment: |
hugovk commented Dec 23, 2022
I have made the requested changes; please review again. Thanks, updated, and I'd also missed I also fixed a bit of formatting whilst these files are being updated. |
bedevere-bot commented Dec 23, 2022
Thanks for making the requested changes! @hauntsaninja: please review the changes made to this pull request. |
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments! Good catch on SMTP.starttls (I didn't check for any other errors of omission)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Doc/library/http.client.rst Outdated
| .. class:: HTTPSConnection(host, port=None, key_file=None, \ | ||
| cert_file=None[, timeout], \ | ||
| .. class:: HTTPSConnection(host, port=None[, timeout], \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't leave a suggestion, but this one needs to be made keyword-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 25421ff
hauntsaninja commented Dec 23, 2022
Btw, subject for a separate discussion, but I've never really liked the |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hugovk commented Dec 27, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Thanks both for the reviews!
Yeah, I guess def__init__(self, host, port=None, timeout=socket._GLOBAL_DEFAULT_TIMEOUT, source_address=None, blocksize=8192): |
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
In the following modules, these parameters were removed (in #94173) after being deprecated in Python 3.6:
This PR updates the documentation to remove the parameters and note their removal in 3.12.
Preview