gh-100488: Add is_integer method to fractions.Fraction#100489
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
hauntsaninja commented Dec 24, 2022
The documentation guarantees that denominator is in lowest term. It doesn't make any explicit guarantee about being positive, but |
JelleZijlstra approved these changes Dec 24, 2022
Member
JelleZijlstra left a comment
JelleZijlstra left a comment There was a problem hiding this comment.
(But let's wait for Mark to also give feedback.)
mdickinson approved these changes Dec 29, 2022
Member
mdickinson left a comment
mdickinson left a comment There was a problem hiding this comment.
LGTM; one reST markup nitpick.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_integerto fractions.Fraction #100488