GH-100126: Skip incomplete frames in more places#100613
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
brandtbucher added interpreter-core brandtbucher added the 🔨 test-with-buildbots 
bedevere-bot commented Dec 30, 2022
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 53d066e 🤖 If you want to schedule another build, you need to add the |
bedevere-bot removed the 🔨 test-with-buildbots 
MemberAuthor
brandtbucher commented Dec 30, 2022
The one failing buildbot (ARM64 Windows) has been failing on other PRs too. |
Member
markshannon left a comment
markshannon left a comment There was a problem hiding this comment.
One quibble about naming.
Looks good. Hopefully this is the last of the frame stack traversal issues.
Include/internal/pycore_frame.h Outdated
| } | ||
| staticinline_PyInterpreterFrame* | ||
| _PyFrame_GetComplete(_PyInterpreterFrame*frame) |
Member
There was a problem hiding this comment.
This name gives no sense of traversing the stack until a complete frame is found.
Maybe _PyFrame_GetFirstComplete()?
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, add two new internal APIs (
_PyFrame_GetCompleteand_PyThreadState_GetFrame) to make this common move a bit cleaner.tstate->cframe->current_frame) #100126