gh-100739: Respect mock spec when checking for unsafe prefixes#100740
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bedevere-bot commented Jan 4, 2023
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
sobolevn reviewed Jan 4, 2023
Misc/NEWS.d/next/Library/2023-01-04-09-53-38.gh-issue-100740.-j5UjI.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
carljm reviewed Jan 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
…j5UjI.rst Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Member
carljm commented Jan 4, 2023
(Note, generally don't ever force-push to a PR, it disrupts incremental review. The commits will be squashed on merge anyway, so there's no harm in having the PR be a series of commits reflecting its development.) |
cjw296 approved these changes Jan 4, 2023
AlexWaygood added needs backport to 3.10 
Contributor
miss-islington commented Jan 4, 2023
Contributor
miss-islington commented Jan 4, 2023
bedevere-bot commented Jan 4, 2023
GH-100760 is a backport of this pull request to the 3.11 branch. |
bedevere-bot commented Jan 4, 2023
GH-100761 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2023
…ythonGH-100740) (cherry picked from commit 7f1eefc) Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2023
…ythonGH-100740) (cherry picked from commit 7f1eefc) Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 4, 2023
miss-islington added a commit that referenced this pull request Jan 4, 2023
carljm added a commit to carljm/cpython that referenced this pull request Jan 5, 2023
* main: pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753) pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702) Drop myself from pathlib maintenance (python#100757) pythongh-100739: Respect mock spec when checking for unsafe prefixes (python#100740)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect Mock spec for attribute names starting with assert (and typos)