Skip to content

GH-98831: Add some tests for generate_cases.py#100763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 3 commits into from
Jan 6, 2023
Merged

GH-98831: Add some tests for generate_cases.py #100763

gvanrossum merged 3 commits into from
Jan 6, 2023

Conversation

@gvanrossum
Copy link
Member

@gvanrossumgvanrossum commented Jan 5, 2023•
edited by bedevere-bot
Loading

  • This doesn't cover everything (far from it) but it's a start.
  • This uses pytest, which isn't ideal, but was quickest to get started.

@bedevere-botbedevere-bot mentioned this pull request Jan 5, 2023
Closed
@bedevere-botbedevere-bot added the tests Tests in the Lib/test dir label Jan 5, 2023
kumaraditya303
kumaraditya303 reviewed Jan 5, 2023
View reviewed changes
iritkatriel
iritkatriel reviewed Jan 5, 2023
View reviewed changes
Tools/cases_generator/test_generator.py Outdated
import generate_cases


def run_test(input: str, expected: str):
Copy link
Member

@iritkatrieliritkatrielJan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe run_cases_test, because we will also have a run_metadata test?

gvanrossumand others added 3 commits January 5, 2023 14:09
@gvanrossum
Add some tests for generate_cases.py
01881a4
- This doesn't cover everything (far from it) but it's a start. - This uses pytest, which isn't ideal, but was quickest to get started.
@gvanrossum
Rename run_test() to run_cases_test()
f422ea9
In anticipation of run_opcode_test().
@gvanrossum@kumaraditya303
Fix f-string
e06aa07
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@gvanrossum
Copy link
MemberAuthor

gvanrossum commented Jan 5, 2023

Ready for review again.

@gvanrossumgvanrossum merged commit 9ffbc58 into python:mainJan 6, 2023
@gvanrossumgvanrossum deleted the cases-test branch January 6, 2023 16:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 left review comments

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gvanrossum@iritkatriel@kumaraditya303@bedevere-bot