gh-100815: Normalize types module usage in copy module#100816
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
terryjreedy approved these changes Jan 7, 2023
Member
terryjreedy left a comment
terryjreedy left a comment There was a problem hiding this comment.
I consider the false implication of the getattr and test to be a buglet.
The changes for None, etc, are not necessary, but given that the types module is already imported, I think using it consistently as the source of truth is a good idea.
In the deepcopy list, I think that the CodeType line should have been just above the function lines, but I am refraining from suggesting that it be moved now.
AlexWaygood approved these changes Jan 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typesmodule usage incopymodule #100815