Skip to content

gh-39615: Add warnings.warn() skip_file_prefixes support#100840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gpshead merged 3 commits into from
Jan 28, 2023
Merged

gh-39615: Add warnings.warn() skip_file_prefixes support #100840

gpshead merged 3 commits into from
Jan 28, 2023

Conversation

@gpshead
Copy link
Member

@gpsheadgpshead commented Jan 8, 2023•
edited
Loading

warnings.warn() gains the ability to skip stack frames based on code filename prefix rather than only a numeric stacklevel= via a new skip_file_prefixes= keyword argument.

My motivation work finally tackling this feature: It will avoid the hacks around putting the warning in the right place in #100618.

@gpshead
pythongh-39615: Add warn() skip_file_prefixes= support.
c0c19a4
`warnings.warn()` gains the ability to skip stack frames based on code filename prefix rather than only a numeric `stacklevel=` via a new `skip_file_prefixes=` keyword argument.
@gpsheadgpshead added type-feature A feature request or enhancement stdlib Standard Library Python modules in the Lib/ directory labels Jan 8, 2023
@bedevere-botbedevere-bot mentioned this pull request Jan 8, 2023
Closed
@gpsheadgpshead self-assigned this Jan 23, 2023
@gpsheadgpshead requested a review from Yhg1sJanuary 25, 2023 02:53
brettcannon
brettcannon approved these changes Jan 27, 2023
View reviewed changes
merwok
merwok reviewed Jan 28, 2023
View reviewed changes
@gpsheadgpshead merged commit 052f53d into python:mainJan 28, 2023
@gpsheadgpshead deleted the feature/warn/skip branch January 28, 2023 02:35
merwok
merwok reviewed Jan 28, 2023
View reviewed changes
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@gpshead@mdboom
pythongh-39615: Add warnings.warn() skip_file_prefixes support (pytho…
1939cb0
…n#100840) `warnings.warn()` gains the ability to skip stack frames based on code filename prefix rather than only a numeric `stacklevel=` via a new `skip_file_prefixes=` keyword argument.
@encukouencukou mentioned this pull request Apr 2, 2024
Merged
1 task
wimglenn added a commit to wimglenn/cpython that referenced this pull request Aug 13, 2024
@wimglenn
Skip re pkg frames in warnings
2581e10
This uses the warnings feature skip_file_prefixes added in 3.12 python#100840
@reyammerreyammer mentioned this pull request Mar 27, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwokmerwokmerwok left review comments

@brettcannonbrettcannonbrettcannon approved these changes

@Yhg1sYhg1sAwaiting requested review from Yhg1s

Assignees

@gpsheadgpshead

Labels

stdlibStandard Library Python modules in the Lib/ directorytype-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gpshead@brettcannon@merwok@bedevere-bot