Skip to content

gh-100871: Improve copy module tests#100872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 3 commits into from
Jan 11, 2023
Merged

gh-100871: Improve copy module tests #100872

miss-islington merged 3 commits into from
Jan 11, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Jan 9, 2023•
edited by miss-islington
Loading

CC @AlexWaygood as the reviewer of #100818

Automerge-Triggered-By: GH:AlexWaygood

@bedevere-botbedevere-bot mentioned this pull request Jan 9, 2023
Closed
@bedevere-botbedevere-bot added the tests Tests in the Lib/test dir label Jan 9, 2023
@AlexWaygoodAlexWaygood self-requested a review January 9, 2023 07:38
@sobolevn
Copy link
MemberAuthor

sobolevn commented Jan 9, 2023

The failure is clearly not related.

hauntsaninja
hauntsaninja approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for this PR! (And good catch on the other PR, Alex!)

hauntsaninja
hauntsaninja reviewed Jan 9, 2023
View reviewed changes
hauntsaninja
hauntsaninja reviewed Jan 9, 2023
View reviewed changes
AlexWaygood
AlexWaygood requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mostly looks good, but two nits below:

@bedevere-bot
Copy link

bedevere-bot commented Jan 9, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 9, 2023

And if you don't make the requested changes, you will be poked with soft cushions!

I have them ready

@sobolevn@AlexWaygood
Apply suggestions from code review
2fd1a25
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Status check is done, and it's a success ✅.

@miss-islingtonmiss-islington merged commit 729ab9b into python:mainJan 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Sorry @sobolevn, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 729ab9b622957fef0e9b494af9a71ab02986c741 3.11

@miss-islingtonmiss-islington self-assigned this Jan 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Sorry, @sobolevn, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 729ab9b622957fef0e9b494af9a71ab02986c741 3.10

@AlexWaygoodAlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jan 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Sorry @sobolevn, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 729ab9b622957fef0e9b494af9a71ab02986c741 3.11

@AlexWaygoodAlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jan 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 11, 2023

Sorry, @sobolevn, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 729ab9b622957fef0e9b494af9a71ab02986c741 3.11

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 11, 2023

@sobolevn, would you be able to handle the backports here? :)

@sobolevn
Copy link
MemberAuthor

sobolevn commented Jan 11, 2023

Yeap, I will add this to my backports queue :)

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 11, 2023

Thank you! Ping me for review when you do, and I'll merge them :)

@bedevere-bot
Copy link

bedevere-bot commented Jan 12, 2023

GH-100975 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 12, 2023
sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 12, 2023
@sobolevn
[3.10]pythongh-100871: Improvecopymodule tests (pythonGH-100872)
cd2738f
CC @AlexWaygood as the reviewer of python#100818 Automerge-Triggered-By: GH:AlexWaygood. (cherry picked from commit 729ab9b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

bedevere-bot commented Jan 12, 2023

GH-100976 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jan 12, 2023
sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 12, 2023
@sobolevn
[3.11]pythongh-100871: Improvecopymodule tests (pythonGH-100872)
cfecbca
CC @AlexWaygood as the reviewer of python#100818 Automerge-Triggered-By: GH:AlexWaygood. (cherry picked from commit 729ab9b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
AlexWaygood pushed a commit that referenced this pull request Jan 12, 2023
@sobolevn
[3.10]gh-100871: Improvecopymodule tests (GH-100872) (#100975)
ebc1fd3
(cherry picked from commit 729ab9b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
AlexWaygood pushed a commit that referenced this pull request Jan 12, 2023
@sobolevn
[3.11]gh-100871: Improvecopymodule tests (GH-100872) (#100976)
db26437
(cherry picked from commit 729ab9b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

@sobolevnsobolevn

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn@bedevere-bot@AlexWaygood@miss-islington@hauntsaninja