Skip to content

Fix typos in Doc folder#100880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 3 commits into from
Jan 10, 2023
Merged

Fix typos in Doc folder #100880

hugovk merged 3 commits into from
Jan 10, 2023

Conversation

@ss18
Copy link
Contributor

@ss18ss18 commented Jan 9, 2023•
edited
Loading

Addressed issue: #100879

Fixed typos:
adviced -> advised
funtion -> function
preferrably -> preferably

Found with: https://github.com/ss18/grep-typos

@ghost
Copy link

ghost commented Jan 9, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

hugovk
hugovk requested changes Jan 9, 2023
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Jan 9, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

wookie184
wookie184 reviewed Jan 9, 2023
View reviewed changes
wookie184
wookie184 reviewed Jan 9, 2023
View reviewed changes
@ss18
Copy link
ContributorAuthor

ss18 commented Jan 9, 2023

@hugovk@wookie184 Thanks for feedback.

Deleted two commits:
publically -> publicly
ressemble -> resemble

@CAM-GerlachCAM-Gerlach added the docs Documentation in the Doc dir label Jan 10, 2023
hugovk
hugovk requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ss18 Thanks for the update, please could you also remove "seeked -> sought"?

@ss18
Copy link
ContributorAuthor

ss18 commented Jan 10, 2023

no problem, @hugovk removed "seeked -> sought".

@ss18ss18 requested review from hugovk and removed request for berkerpeksag and erlend-aaslandJanuary 10, 2023 08:53
@hugovkhugovk removed the request for review from a teamJanuary 10, 2023 09:03
hugovk
hugovk approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hugovkhugovk merged commit 35650f2 into python:mainJan 10, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jan 10, 2023

Thanks @ss18 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 10, 2023

Sorry, @ss18 and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 35650f25383efce83b62d5273110ab8dcdbcc254 3.11

@miss-islington
Copy link
Contributor

miss-islington commented Jan 10, 2023

Sorry @ss18 and @hugovk, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 35650f25383efce83b62d5273110ab8dcdbcc254 3.10

@bedevere-bot
Copy link

bedevere-bot commented Jan 10, 2023

GH-100914 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jan 10, 2023
@bedevere-bot
Copy link

bedevere-bot commented Jan 10, 2023

GH-100915 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 10, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull request Jan 10, 2023
@ss18@hugovk
[3.11] Fix typos in Doc folder (pythonGH-100880).
dc9ec09
(cherry picked from commit 35650f2) Co-authored-by: Semen Zhydenko <semen.zhydenko@gmail.com>
hugovk added a commit that referenced this pull request Jan 10, 2023
@hugovk@ss18
[3.11] Fix typos in Doc folder (GH-100880). (#100914)
1e74a12
Co-authored-by: Semen Zhydenko <semen.zhydenko@gmail.com>
hugovk added a commit that referenced this pull request Jan 10, 2023
@hugovk@ss18
[3.10] Fix typos in Doc folder (GH-100880). (#100915)
65b01b2
Co-authored-by: Semen Zhydenko <semen.zhydenko@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja left review comments

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments

@hugovkhugovkhugovk approved these changes

+1 more reviewer

@wookie184wookie184wookie184 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hugovkhugovk

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ss18@bedevere-bot@miss-islington@hugovk@hauntsaninja@CAM-Gerlach@wookie184