Skip to content

gh-100668: Clarify how sqlite3 maps parameters onto placeholders#100960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 4 commits into from
Jan 14, 2023
Merged

gh-100668: Clarify how sqlite3 maps parameters onto placeholders #100960

erlend-aasland merged 4 commits into from
Jan 14, 2023

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Jan 11, 2023•
edited by bedevere-bot
Loading

@erlend-aaslanderlend-aasland changed the title gh-100668: Clarify how sqlite3 maps parameters onto placeholdersGH-100668: Clarify how sqlite3 maps parameters onto placeholdersJan 11, 2023
@erlend-aaslanderlend-aasland linked an issue Jan 11, 2023 that may be closed by this pull request
Clarify how sqlite3 maps parameters onto placeholders #100668
Closed
@erlend-aaslanderlend-aasland changed the title GH-100668: Clarify how sqlite3 maps parameters onto placeholdersgh-100668: Clarify how sqlite3 maps parameters onto placeholdersJan 11, 2023
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Jan 11, 2023

What's up with Bedevere? The PR title is correct, and it points to a valid issue number.

erlend-aasland
erlend-aasland commented Jan 11, 2023
View reviewed changes
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Jan 11, 2023

cc. @zzzeek

zzzeek
zzzeek reviewed Jan 12, 2023
View reviewed changes
@bedevere-botbedevere-bot mentioned this pull request Jan 13, 2023
Closed
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Jan 13, 2023

What's up with Bedevere? The PR title is correct, and it points to a valid issue number.

Not 100% sure if you mean how come it didn't link the issue and the PR, or something else it did, but if you mean the former, it appears you added a skip issue label when you submitted the PR, which made Bedevere not attempt to link it. I removed that, and everything appears to work fine.

CAM-Gerlach
CAM-Gerlach reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to fix some textual issues; otherwise, LGTM

@erlend-aaslanderlend-aasland merged commit 206f05a into python:mainJan 14, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jan 14, 2023

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aaslanderlend-aasland deleted the sqlite-docs/params-and-placeholders branch January 14, 2023 22:58
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2023
@erlend-aasland@CAM-Gerlach@miss-islington
pythongh-100668: Clarify how sqlite3 maps parameters onto placeholders (
8d62a96
pythonGH-100960) (cherry picked from commit 206f05a) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-bot
Copy link

bedevere-bot commented Jan 14, 2023

GH-101044 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jan 14, 2023
@bedevere-bot
Copy link

bedevere-bot commented Jan 14, 2023

GH-101045 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 14, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2023
@erlend-aasland@CAM-Gerlach@miss-islington
pythongh-100668: Clarify how sqlite3 maps parameters onto placeholders (
3eb7f3d
pythonGH-100960) (cherry picked from commit 206f05a) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull request Jan 14, 2023
@miss-islington@erlend-aasland@CAM-Gerlach
gh-100668: Clarify how sqlite3 maps parameters onto placeholders (GH-…
c7aa392
…100960) (cherry picked from commit 206f05a) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull request Jan 14, 2023
@miss-islington@erlend-aasland@CAM-Gerlach
gh-100668: Clarify how sqlite3 maps parameters onto placeholders (GH-…
1981db9
…100960) (cherry picked from commit 206f05a) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

+1 more reviewer

@zzzeekzzzeekzzzeek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify how sqlite3 maps parameters onto placeholders

5 participants

@erlend-aasland@CAM-Gerlach@miss-islington@bedevere-bot@zzzeek