gh-101056: Fix memory leak in formatfloat() in bytesobject.c#101057
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mdickinson approved these changes Jan 15, 2023
Member
mdickinson left a comment
mdickinson left a comment There was a problem hiding this comment.
LGTM. Probably worth running the buildbots on this, though.
mdickinson added the 🔨 test-with-buildbots 
bedevere-bot commented Jan 15, 2023
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 8e1b415 🤖 If you want to schedule another build, you need to add the |
bedevere-bot removed the 🔨 test-with-buildbots 
kumaraditya303 approved these changes Jan 16, 2023
kumaraditya303 added needs backport to 3.10 
Contributor
miss-islington commented Jan 16, 2023
Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
miss-islington commented Jan 16, 2023
Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commented Jan 16, 2023
GH-101076 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2023
pythonGH-101057) (cherry picked from commit b1a74a1) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
bedevere-bot commented Jan 16, 2023
GH-101077 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2023
pythonGH-101057) (cherry picked from commit b1a74a1) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs say: