Skip to content

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented Jan 19, 2023

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Maybe it's time to add some tests for the generated opcode metadata (but I'm not asking for that now).

@iritkatriel
Copy link
MemberAuthor

It failed very quickly when I tried to use it (the sanity check we added in the compiler flipped).

@gvanrossum
Copy link
Member

gvanrossum commented Jan 19, 2023

Is it ready to merge?

Note: there are other things in the generator that probably don't work, e.g. there are some commented-out out.emit(f"JUMPBY(OPSIZE(... calls. But those might be not needed if we go ahead with the variable-length scheme.

@iritkatriel
Copy link
MemberAuthor

Is it ready to merge?

I think so.

Note: there are other things in the generator that probably don't work, e.g. there are some commented-out out.emit(f"JUMPBY(OPSIZE(... calls. But those might be not needed if we go ahead with the variable-length scheme.

I'm not doing variable length instructions now. I'm adding the plumbing in the compiler, and for now supporting only 1 oparg (so I can do RETURN_VALUE from a tmp register). There's plenty there to keep me busy for now.

@iritkatrieliritkatriel merged commit 8a2d4f4 into python:mainJan 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel@gvanrossum@bedevere-bot