GH-92123: Store _elementtree state in type contexts#101190
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
erlend-aaslandforce-pushed the etree/state-as-type-context-member branch from b1127be to b2698e2Compare
erlend-aaslandforce-pushed the etree/state-as-type-context-member branch from 007ccb5 to 4f0f2ffCompareContributorAuthor
erlend-aasland commented Jan 22, 2023
How about this: we store state in the type context for the TreeBuilder and XMLParser. The state pointer should be valid throughout the lifetime of the heap type, since each heap type has a reference to its module. After landing this, I'll rebase #101189 onto |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.