[3.11] GH-100762: Don't call gen.throw() in gen.close(), unless necessary#101316
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
markshannon changed the title 
Member
brandtbucher left a comment
brandtbucher left a comment There was a problem hiding this comment.
Do we still want to do this? The code looks fine to me... I'm not sure why the tests are failing, but it definitely seems related.
MemberAuthor
markshannon commented Sep 28, 2023
Given 3.13 will be released soon and this is working in 3.12, I don't think it is worth investigating further why this doesn't work. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a backport of #101013 in principle, although the mechanism for determining when to skip the call to
throw()is different.