Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commented Oct 26, 2018

Declare functions with EXTINLINE:

  • mpd_del()
  • mpd_uint_zero()
  • mpd_qresize()
  • mpd_qresize_zero()
  • mpd_minalloc()

These functions are implemented with "inline" or "ALWAYS_INLINE", but
declared without inline which cause linker error on Visual Studio in
Debug mode when using /Ob1.
(cherry picked from commit 3b1cba3)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue35059

…0128) Declare functions with EXTINLINE: * mpd_del() * mpd_uint_zero() * mpd_qresize() * mpd_qresize_zero() * mpd_minalloc() These functions are implemented with "inline" or "ALWAYS_INLINE", but declared without inline which cause linker error on Visual Studio in Debug mode when using /Ob1. (cherry picked from commit 3b1cba3) Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
ContributorAuthor

@vstinner: Status check is done, and it's a success ✅ .

@miss-islingtonmiss-islington merged commit 95cfb81 into python:3.7Oct 26, 2018
@miss-islingtonmiss-islington deleted the backport-3b1cba3-3.7 branch October 26, 2018 17:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington@vstinner@the-knights-who-say-ni@bedevere-bot