gh-98831: Modernize CALL_FUNCTION_EX#101627
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
gvanrossum commented Feb 7, 2023
On top of that the tests fail. Going back into draft mode. |
Also avoid compiler warning for unused variable 'null' (used in assert only).
gvanrossumforce-pushed the call-function-ex branch from 10dcbec to 19307baComparegvanrossum added the 🔨 test-with-refleak-buildbots 
bedevere-bot commented Feb 7, 2023
🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 19307ba 🤖 If you want to schedule another build, you need to add the |
bedevere-bot removed the 🔨 test-with-refleak-buildbots MemberAuthor
gvanrossum commented Feb 7, 2023
@iritkatriel Crash fixed, warning fixed, tests passed, refleak buildbots are running. Ready for your review. |
iritkatriel approved these changes Feb 7, 2023
MemberAuthor
gvanrossum commented Feb 8, 2023
I'm taking the PPC64LE RHEL8 Refleaks PR buildbot failure as a flake. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a straightforward use of a conditional input stack effect. The one tricky bit is that I had to cherry-pick a fix for CHECK_EVAL_BREAKER() from gh-101508. Whichever lands first, the other will have to drop that commit.