Skip to content

gh-101670: typo fix in PyImport_AppendInittab()#101672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 1 commit into from
Feb 8, 2023
Merged

gh-101670: typo fix in PyImport_AppendInittab() #101672

miss-islington merged 1 commit into from
Feb 8, 2023

Conversation

@skirpichev
Copy link
Member

@skirpichevskirpichev commented Feb 8, 2023•
edited by miss-islington
Loading

@bedevere-botbedevere-bot mentioned this pull request Feb 8, 2023
Closed
@hugovk
Copy link
Member

hugovk commented Feb 8, 2023

Is a news file needed?

I think a backport to 3.11 and 3.10 would be useful.

@hugovkhugovk added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 8, 2023
@arhadthedev
Copy link
Member

arhadthedev commented Feb 8, 2023

Is a news file needed?

@hugovk I think no because it's a typo, not a factual mistake.

ericsnowcurrently
ericsnowcurrently approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islingtonmiss-islington merged commit 35dd550 into python:mainFeb 8, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Feb 8, 2023

Thanks @skirpichev for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 8, 2023

Sorry @skirpichev, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 35dd55005ee9aea2843eff7f514ee689a0995df8 3.11

@miss-islingtonmiss-islington self-assigned this Feb 8, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Feb 8, 2023

Sorry, @skirpichev, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 35dd55005ee9aea2843eff7f514ee689a0995df8 3.10

@skirpichevskirpichev deleted the fix-101670 branch February 9, 2023 00:23
@skirpichev
Copy link
MemberAuthor

skirpichev commented Feb 9, 2023

@hugovk, typo was added in 7f3a4b9, so you can clear requirements to backport.

BTW, there are actually two typos in the commit.

@hugovkhugovk removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 9, 2023
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Feb 9, 2023

BTW, thanks for fixing this (and so quickly), @skirpichev!

@ericsnowcurrentlyericsnowcurrently mentioned this pull request Feb 9, 2023
Merged
carljm added a commit to carljm/cpython that referenced this pull request Feb 9, 2023
@carljm
Merge branch 'main' into inlinecomp2
be3becc
* main: (82 commits) pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723) pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736) no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731) pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730) pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679) pythongh-85984: Remove legacy Lib/pty.py code. (python#92365) pythongh-98831: Use opcode metadata for stack_effect() (python#101704) pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719) pythongh-101283: Fix use of unbound variable (pythonGH-101712) pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286) pythongh-101277: Port more itertools static types to heap types (python#101304) pythongh-98831: Modernize CALL and family (python#101508) pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697) pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329) pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672) pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324) pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615) pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934) pythonGH-101578: Normalize the current exception (pythonGH-101607) pythongh-47937: Note that Popen attributes are read-only (python#93070) ...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@hugovkhugovkhugovk approved these changes

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@encukouencukouAwaiting requested review from encukou

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

@miss-islingtonmiss-islington

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@skirpichev@hugovk@arhadthedev@miss-islington@ericsnowcurrently@bedevere-bot