Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-101865: Deprecate co_lnotab from code objects as per PEP 626#101866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
sobolevn commented Feb 13, 2023 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
sobolevn commented Feb 13, 2023
I've pushed my naive attempt to fix |
sobolevn commented Feb 21, 2023
@markshannon friendly ping :) |
…cts as per PEP626" This reverts commit 06a79d9.
co_lnotab from code objects as per PEP626co_lnotab from code objects as per PEP626sobolevn commented Feb 22, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Failures do not seem related 🤔 |
arhadthedev commented Feb 25, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
|
sobolevn commented Mar 11, 2023
@markshannon do you have time to re-review this, please? :) |
sobolevn commented Mar 18, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@carljm maybe you can have a look? :) |
markshannon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
We aren't obliged to remove co_lnotab in 3.14, but we can. Perhaps change the "will"s to "may"s.
Not sure what to do about Misc/gdbinit though.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
markshannon commented Mar 18, 2023
Perhaps we should discuss the future of Misc/gdbinit in another issue, and not worry about it here. |
sobolevn commented Mar 18, 2023
@markshannon thanks a lot for your review and for all your hard work on CPython!
|
hugovk commented Mar 18, 2023
Shall we add a |
co_lnotab from code objects as per PEP626co_lnotab from code objects as per PEP 626sobolevn commented Mar 19, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I think that we can add "is deprecated since 3.12 and may be removed in 3.14". |
hugovk commented Mar 19, 2023
Sure, let's do something like that. |
sobolevn commented Mar 21, 2023
|
sobolevn commented Apr 3, 2023
@markshannon I've solved the merge conflicts. I hope that this is ready to be merged when you have the time :) |
…26 (python#101866) Co-authored-by: Oleg Iarygin <[email protected]>
…26 (python#101866) Co-authored-by: Oleg Iarygin <[email protected]>
I still have to fix these lines:
cpython/Misc/gdbinit
Lines 60 to 61 in 6ef6915
But, since I have 0 experience with
gdbit might take some time.co_lnotabmust be removed in 3.12 according to PEP 626 #101865