Skip to content

Conversation

@corona10
Copy link
Member

@corona10corona10 commented Feb 17, 2023

@corona10corona10 changed the title Revert "gh-101766: Fix refleak for _BlockingOnManager resources (gh-1…gh-101766: Fix refleak for _BlockingOnManager resources from test suite levelFeb 17, 2023
@corona10
Copy link
MemberAuthor

corona10 commented Feb 17, 2023

@exarkun@gvanrossum@sobolevn

  • I revert the 775f881 since @exarkun pointed out that the change will cause the regression which was already resolved.
    see: gh-101766: Fix refleak for _BlockingOnManager resources #101942 (comment)
  • Rather than I tried to clean up the global dictionary at the test suite level. It will reduce the possibility of leakage at the test level. (Not 100% but it doesn't occur under 10 times of execution. but without this patch, the leak was reproduced within 10 times of execution)

@corona10corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @corona10 for commit a85f0e6 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this turned out way more complex than I initially thought! 👍

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works too. Many tests do something like this. Is there standard infrastructure for clearing caches?

@corona10
Copy link
MemberAuthor

This works too. Many tests do something like this. Is there standard infrastructure for clearing caches?

I am not sure, let's create a issue for that. We will need it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@bedevere-bot@gvanrossum@sobolevn