Skip to content

Conversation

@jaraco
Copy link
Member

@jaracojaraco commented Feb 18, 2023

@jaracojaraco self-assigned this Feb 18, 2023
@jaraco
Copy link
MemberAuthor

Those test failures are interesting. They certainly seem related to the changes. But that doesn't explain why the tests pass for me locally or why they pass in importlib_resources. I'll continue to investigate.

@jaracojaracoforce-pushed the sync/importlib-resources-5.12 branch from db3a1dd to 4d92e56CompareFebruary 18, 2023 15:35
@jaraco
Copy link
MemberAuthor

Aah. The issue was that new files were added but not included in the commit (the usual foot gun aka git). I probably wouldn't have encountered that error had I been using jj.

@jaracojaracoforce-pushed the sync/importlib-resources-5.12 branch from 4d92e56 to 0660828CompareFebruary 18, 2023 15:36
@jaraco
Copy link
MemberAuthor

The remaining test is failing for unrelated reasons. Merging. Thanks for the review!

@jaracojaraco merged commit 5170caf into python:mainFeb 18, 2023
@jaracojaraco deleted the sync/importlib-resources-5.12 branch February 18, 2023 21:29
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Clang Installed 3.x has failed when building commit 5170caf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/14/builds/3250) and take a look at the build logs.
  4. Check if the failure is related to this commit (5170caf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/14/builds/3250

Failed tests:

  • test_importlib

Failed subtests:

  • test_join_path_common_subdir - test.test_importlib.resources.test_reader.MultiplexedPathTest.test_join_path_common_subdir

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

411 tests OK.

1 test failed:
test_importlib

19 tests skipped:
test_asdl_parser test_check_c_globals test_clinic test_devpoll
test_gdb test_ioctl test_kqueue test_launcher test_msilib
test_peg_generator test_startfile test_tix test_tkinter test_ttk
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test_importlib

Total duration: 2 min 36 sec

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.12/test/test_importlib/resources/test_reader.py", line 89, in test_join_path_common_subdirself.assertIsInstance(path.joinpath('subdirectory'), MultiplexedPath) AssertionError: PosixPath('/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.12/test/test_importlib/resources/data01/subdirectory') is not an instance of <class 'importlib.resources.readers.MultiplexedPath'>

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang Installed 3.x has failed when building commit 5170caf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/531/builds/3353) and take a look at the build logs.
  4. Check if the failure is related to this commit (5170caf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/531/builds/3353

Failed tests:

  • test_importlib

Failed subtests:

  • test_join_path_common_subdir - test.test_importlib.resources.test_reader.MultiplexedPathTest.test_join_path_common_subdir

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

408 tests OK.

1 test failed:
test_importlib

22 tests skipped:
test_asdl_parser test_check_c_globals test_clinic test_devpoll
test_gdb test_ioctl test_kqueue test_launcher test_msilib test_nis
test_peg_generator test_perf_profiler test_readline test_startfile
test_tix test_tkinter test_ttk test_winconsoleio test_winreg
test_winsound test_wmi test_zipfile64

1 re-run test:
test_importlib

Total duration: 3 min 53 sec

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.12/test/test_importlib/resources/test_reader.py", line 89, in test_join_path_common_subdirself.assertIsInstance(path.joinpath('subdirectory'), MultiplexedPath) AssertionError: PosixPath('/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.12/test/test_importlib/resources/data01/subdirectory') is not an instance of <class 'importlib.resources.readers.MultiplexedPath'>

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang Installed 3.x has failed when building commit 5170caf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/350/builds/3193) and take a look at the build logs.
  4. Check if the failure is related to this commit (5170caf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/350/builds/3193

Failed tests:

  • test_asyncio
  • test_importlib

Failed subtests:

  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks
  • test_join_path_common_subdir - test.test_importlib.resources.test_reader.MultiplexedPathTest.test_join_path_common_subdir

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

411 tests OK.

1 test failed:
test_importlib

19 tests skipped:
test_asdl_parser test_check_c_globals test_clinic test_devpoll
test_gdb test_ioctl test_kqueue test_launcher test_msilib
test_peg_generator test_startfile test_tix test_tkinter test_ttk
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

2 re-run tests:
test_asyncio test_importlib

Total duration: 2 min 53 sec

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.12/test/test_asyncio/test_subprocess.py", line 771, in test_subprocess_consistent_callbacksself.loop.run_until_complete(main()) File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.12/asyncio/base_events.py", line 664, in run_until_completereturn future.result() ^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.12/test/test_asyncio/test_subprocess.py", line 763, in mainself.assertEqual(events, [ AssertionError: Lists differ: [('pi[69 chars]), 'process_exited', 'pipe_connection_lost', '[17 chars]ost'] != [('pi[69 chars]), 'pipe_connection_lost', 'pipe_connection_lo[17 chars]ted'] Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.12/test/test_importlib/resources/test_reader.py", line 89, in test_join_path_common_subdirself.assertIsInstance(path.joinpath('subdirectory'), MultiplexedPath) AssertionError: PosixPath('/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.12/test/test_importlib/resources/data01/subdirectory') is not an instance of <class 'importlib.resources.readers.MultiplexedPath'>

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit 5170caf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/464/builds/3848) and take a look at the build logs.
  4. Check if the failure is related to this commit (5170caf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/464/builds/3848

Failed tests:

  • test_importlib

Failed subtests:

  • test_join_path_common_subdir - test.test_importlib.resources.test_reader.MultiplexedPathTest.test_join_path_common_subdir

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

413 tests OK.

1 test failed:
test_importlib

17 tests skipped:
test_asdl_parser test_check_c_globals test_clinic test_devpoll
test_gdb test_ioctl test_kqueue test_launcher test_msilib
test_peg_generator test_perf_profiler test_startfile
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test_importlib

Total duration: 23 min 18 sec

Click to see traceback logs
Traceback (most recent call last): File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.12/test/test_importlib/resources/test_reader.py", line 89, in test_join_path_common_subdirself.assertIsInstance(path.joinpath('subdirectory'), MultiplexedPath) AssertionError: PosixPath('/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.12/test/test_importlib/resources/data01/subdirectory') is not an instance of <class 'importlib.resources.readers.MultiplexedPath'>

@jaraco
Copy link
MemberAuthor

I suspect the buildbot failures are due to missing directory declarations. Will investigate.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jaraco@bedevere-bot@warsaw@FFY00