Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode#102068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
0x1306e6d commented Feb 20, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Feb 20, 2023
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
ghost commented Feb 20, 2023 • edited by ghost
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by ghost
Uh oh!
There was an error while loading. Please reload this page.
corona10 commented Feb 20, 2023
@ghkim3221 Please add the NEWS.d by using blurb tool :) |
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can verify the encoding at this line if the user assigns the encoding explicitly.
The correct error should be raised.
Lines 402 to 403 in b1b375e
| ifencodingisNone: # EncodingWarning is emitted in FileInput() already. | |
| encoding="locale" |
bedevere-bot commented Feb 20, 2023
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Misc/ACKS Outdated
| Vladimir Kushnir | ||
| Erno Kuusela | ||
| Kabir Kwatra | ||
| Gihwan Kim |
corona10Feb 20, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you have to move up the name to the following order.
Gihwan Kim Jan Kim Taek Joo Kim | withself.assertRaises(ValueError): | ||
| check('rb', ['A\n', 'B\r\n', 'C\r', 'D\u20ac']) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the unrelated change :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thank you
Misc/NEWS.d/next/Library/2023-02-21-10-05-33.gh-issue-101961.7e56jh.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
…e56jh.rst Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
corona10 commented Feb 21, 2023
@ghkim3221 Did you sign up for the CLA? |
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I verified several things in the local environment too.
Thanks for the hard work @ghkim3221 !!
0x1306e6d commented Feb 21, 2023
@corona10 Yes, I signed in. Yesterday, Internal Server Error was returned but the badge was changed to signed. |
Misc/NEWS.d/next/Library/2023-02-21-10-05-33.gh-issue-101961.7e56jh.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
miss-islington commented Feb 21, 2023
Thanks @ghkim3221 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
bedevere-bot commented Feb 21, 2023
GH-102098 is a backport of this pull request to the 3.11 branch. |
…value for the binary mode (pythongh-102068) (cherry picked from commit 6f25657) Co-authored-by: Gihwan Kim <ghkim3221@gmail.com>
…value for the binary mode (pythongh-102068) (cherry picked from commit 6f25657) Co-authored-by: Gihwan Kim <ghkim3221@gmail.com>
bedevere-bot commented Feb 21, 2023
GH-102099 is a backport of this pull request to the 3.10 branch. |
bedevere-bot commented Feb 21, 2023
|
* main: (76 commits) Fix syntax error in struct doc example (python#102160) pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089) pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143) Few coverage nitpicks for the cmath module (python#102067) pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985) pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137) pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356) pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119) pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100) pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009) pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923) pythongh-100556: Improve clarity of `or` docs (python#100589) pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026) pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966) pythongh-101578: Amend exception docs (python#102057) pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068) pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078) pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012) pythongh-101566: Sync with zipp 3.14. (pythonGH-102018) pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) ...
…value for the binary mode (pythongh-102068)
…value for the binary mode (pythongh-102068)
…value for the binary mode (pythongh-102068)
fileinput.hook_compresseddoesn't set the givenNoneencodingtolocaleif the givenmodecontainsb.