Skip to content

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Feb 23, 2023

Automerge-Triggered-By: GH:erlend-aasland

@erlend-aasland
Copy link
ContributorAuthor

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the _testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?

@iritkatriel
Copy link
Member

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the _testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?

It depends, we'd need to see why it's scattered like that. Could be divided on some other criteria.

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islingtonmiss-islington merged commit efc985a into python:mainFeb 23, 2023
@erlend-aaslanderlend-aasland deleted the split-testcapi/exceptions branch February 23, 2023 17:12
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@iritkatriel@miss-islington@bedevere-bot