Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-95675 fix uid and gid at test_add_dir_getmember#102207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
bedevere-bot commented Feb 24, 2023
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
ghost commented Feb 24, 2023 • edited by ghost
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by ghost
Uh oh!
There was an error while loading. Please reload this page.
| self.add_dir_and_getmember('bar') | ||
| self.add_dir_and_getmember('a'*101) | ||
| @unittest.skipIf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please skip the test if hasattr(os, 'getuid') is false or hasattr(os, 'getgid') is false.
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bedevere-bot commented Feb 24, 2023
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
miss-islington commented Feb 25, 2023
miss-islington commented Feb 25, 2023
bedevere-bot commented Feb 25, 2023
GH-102230 is a backport of this pull request to the 3.10 branch. |
bedevere-bot commented Feb 25, 2023
GH-102231 is a backport of this pull request to the 3.11 branch. |
bedevere-bot commented Feb 25, 2023
|
Uh oh!
There was an error while loading. Please reload this page.