Skip to content

gh-102493: fix normalization in PyErr_SetObject#102502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yhg1s merged 8 commits into from
Mar 7, 2023
Merged

gh-102493: fix normalization in PyErr_SetObject #102502

Yhg1s merged 8 commits into from
Mar 7, 2023

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented Mar 7, 2023•
edited by bedevere-bot
Loading

@iritkatrieliritkatriel added type-bug An unexpected behavior, bug, or error release-blocker 3.12 only security fixes labels Mar 7, 2023
@bedevere-botbedevere-bot mentioned this pull request Mar 7, 2023
Closed
ned-deily
ned-deily reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit about the NEWS blurb entry but otherwise I verified that the PR does fix the observed regression with psutil on macOS and that no new test suite regressions are observed. Thanks, @iritkatriel, for the fast work!

@iritkatrieliritkatriel changed the title gh-102493: fix normalisation in PyErr_SetObjectgh-102493: fix normalization in PyErr_SetObjectMar 7, 2023
JelleZijlstra
JelleZijlstra reviewed Mar 7, 2023
View reviewed changes
gvanrossum
gvanrossum reviewed Mar 7, 2023
View reviewed changes
iritkatrieland others added 2 commits March 7, 2023 19:03
@iritkatriel
skip issubclass when not an exception
a9094f9
@iritkatriel@JelleZijlstra
whitespace
6d7bccd
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Yhg1s
Yhg1s reviewed Mar 7, 2023
View reviewed changes
@Yhg1sYhg1s merged commit a33ca2a into python:mainMar 7, 2023
carljm added a commit to carljm/cpython that referenced this pull request Mar 7, 2023
@carljm
Merge branch 'main' into nodeaddict
e391218
* main: pythongh-102493: fix normalization in PyErr_SetObject (python#102502) pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320) pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781) Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398) pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429) pythongh-90110: Fix the c-analyzer Tool (python#102483) pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485) Remove unused import of `warnings` from `unittest.loader` (python#102479) Add gettext support to tools/extensions/c_annotations.py (python#101989)
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
1c019a7
* main: pythongh-102493: fix normalization in PyErr_SetObject (python#102502) pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320) pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781) Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398) pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429) pythongh-90110: Fix the c-analyzer Tool (python#102483) pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485) Remove unused import of `warnings` from `unittest.loader` (python#102479) Add gettext support to tools/extensions/c_annotations.py (python#101989)
@gvanrossumgvanrossum mentioned this pull request Mar 13, 2023
Closed
@iritkatrieliritkatriel deleted the gh-102493 branch April 3, 2023 17:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@gvanrossumgvanrossumgvanrossum approved these changes

@Yhg1sYhg1sYhg1s approved these changes

@ned-deilyned-deilyned-deily approved these changes

@markshannonmarkshannonAwaiting requested review from markshannon

@giampaologiampaoloAwaiting requested review from giampaolo

Assignees

No one assigned

Labels

3.12only security fixesrelease-blockertype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gh-101607 causes regression in third-party psutil package on macOS

6 participants

@iritkatriel@JelleZijlstra@gvanrossum@Yhg1s@ned-deily@bedevere-bot