Skip to content

Conversation

@chgnrdv
Copy link
Contributor

@chgnrdvchgnrdv commented Mar 13, 2023

@chgnrdvchgnrdv requested a review from a team as a code ownerMarch 13, 2023 18:32
@chgnrdvchgnrdv changed the title Remove duplicate include directives from multiple source filesgh-102650 Remove duplicate include directives from multiple source filesMar 13, 2023
@chgnrdvchgnrdv changed the title gh-102650 Remove duplicate include directives from multiple source filesgh-102650: Remove duplicate include directives from multiple source filesMar 13, 2023
@carljmcarljm merged commit 85ba8a3 into python:mainMar 13, 2023
@carljm
Copy link
Member

Merged, thanks!

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 3.x has failed when building commit 85ba8a3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/15/builds/4087) and take a look at the build logs.
  4. Check if the failure is related to this commit (85ba8a3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/15/builds/4087

Failed tests:

  • test_urllib2net

Failed subtests:

  • test_ftp_default_timeout - test.test_urllib2net.TimeoutTest.test_ftp_default_timeout
  • test_ftp - test.test_urllib2net.OtherNetworkTests.test_ftp
  • test_ftp_basic - test.test_urllib2net.TimeoutTest.test_ftp_basic
  • test_ftp_no_timeout - test.test_urllib2net.TimeoutTest.test_ftp_no_timeout
  • test_ftp_timeout - test.test_urllib2net.TimeoutTest.test_ftp_timeout

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

410 tests OK.

10 slowest tests:

  • test_compile: 2 min 35 sec
  • test_concurrent_futures: 2 min 23 sec
  • test_multiprocessing_spawn: 2 min 12 sec
  • test_capi: 1 min 51 sec
  • test_math: 1 min 33 sec
  • test_multiprocessing_forkserver: 1 min 25 sec
  • test_asyncio: 1 min 18 sec
  • test_multiprocessing_fork: 1 min 14 sec
  • test_tokenize: 55.6 sec
  • test_signal: 55.3 sec

1 test failed:
test_urllib2net

23 tests skipped:
test_check_c_globals test_devpoll test_gdb test_idle test_ioctl
test_kqueue test_launcher test_msilib test_peg_generator
test_smtpnet test_ssl test_startfile test_tcl test_tix
test_tkinter test_ttk test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test_urllib2net

Total duration: 4 min 19 sec

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 355, in test_ftp_no_timeoutwith socket_helper.transient_internet(self.FTP_HOST): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/contextlib.py", line 155, in __exit__self.gen.throw(value) File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 269, in transient_internet filter_error(err) File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 238, in filter_error (("ConnectionRefusedError"in err.reason) or^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^TypeError: argument of type 'error_perm' is not iterable Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 250, in transient_internetyield File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 358, in test_ftp_no_timeout u = _urlopen_with_retry(self.FTP_HOST, timeout=None) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 29, in wrappedreturn _retry_thrice(func, exc, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 25, in _retry_thriceraise last_exc File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 21, in _retry_thricereturn func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 215, in urlopenreturn opener.open(url, data, timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 515, in open response =self._open(req, data) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 532, in _open result =self._call_chain(self.handle_open, protocol, protocol +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 492, in _call_chain result = func(*args) ^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 1582, in ftp_openraise URLError(exp) from exp urllib.error.URLError: <urlopen error 500 OOPS: vsf_sysutil_bind> Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 365, in test_ftp_timeoutwith socket_helper.transient_internet(self.FTP_HOST): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/contextlib.py", line 155, in __exit__self.gen.throw(value) File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 269, in transient_internet filter_error(err) File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 238, in filter_error (("ConnectionRefusedError"in err.reason) or^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^TypeError: argument of type 'error_perm' is not iterable Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 337, in test_ftp_basicwith socket_helper.transient_internet(self.FTP_HOST, timeout=None): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/contextlib.py", line 155, in __exit__self.gen.throw(value) File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 269, in transient_internet filter_error(err) File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 238, in filter_error (("ConnectionRefusedError"in err.reason) or^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^TypeError: argument of type 'error_perm' is not iterable Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 344, in test_ftp_default_timeoutwith socket_helper.transient_internet(self.FTP_HOST): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/contextlib.py", line 155, in __exit__self.gen.throw(value) File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 269, in transient_internet filter_error(err) File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 238, in filter_error (("ConnectionRefusedError"in err.reason) or^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^TypeError: argument of type 'error_perm' is not iterable Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 250, in transient_internetyield File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 366, in test_ftp_timeout u = _urlopen_with_retry(self.FTP_HOST, timeout=60) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 29, in wrappedreturn _retry_thrice(func, exc, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 25, in _retry_thriceraise last_exc File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 21, in _retry_thricereturn func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 215, in urlopenreturn opener.open(url, data, timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 515, in open response =self._open(req, data) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 532, in _open result =self._call_chain(self.handle_open, protocol, protocol +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 492, in _call_chain result = func(*args) ^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 1582, in ftp_openraise URLError(exp) from exp urllib.error.URLError: <urlopen error 500 OOPS: vsf_sysutil_bind> Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 257, in _test_urls f = urlopen(url, req, support.INTERNET_TIMEOUT) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 29, in wrappedreturn _retry_thrice(func, exc, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 25, in _retry_thriceraise last_exc File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 21, in _retry_thricereturn func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 515, in open response =self._open(req, data) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 532, in _open result =self._call_chain(self.handle_open, protocol, protocol +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 492, in _call_chain result = func(*args) ^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 1582, in ftp_openraise URLError(exp) from exp urllib.error.URLError: <urlopen error <urlopen error ftp error: 500 OOPS: vsf_sysutil_bind>> Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 1572, in ftp_open fp, retrlen = fw.retrfile(file, type) ^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 2467, in retrfile conn, retrlen =self.ftp.ntransfercmd(cmd) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/ftplib.py", line 353, in ntransfercmd host, port =self.makepasv() ^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/ftplib.py", line 327, in makepasv untrusted_host, port = parse227(self.sendcmd('PASV')) ^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/ftplib.py", line 281, in sendcmdreturnself.getresp() ^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/ftplib.py", line 254, in getrespraise error_perm(resp) ftplib.error_perm: 500 OOPS: vsf_sysutil_bind Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 250, in transient_internetyield File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 338, in test_ftp_basic u = _urlopen_with_retry(self.FTP_HOST) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 29, in wrappedreturn _retry_thrice(func, exc, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 25, in _retry_thriceraise last_exc File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 21, in _retry_thricereturn func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 215, in urlopenreturn opener.open(url, data, timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 515, in open response =self._open(req, data) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 532, in _open result =self._call_chain(self.handle_open, protocol, protocol +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 492, in _call_chain result = func(*args) ^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 1582, in ftp_openraise URLError(exp) from exp urllib.error.URLError: <urlopen error 500 OOPS: vsf_sysutil_bind> Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/support/socket_helper.py", line 250, in transient_internetyield File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 347, in test_ftp_default_timeout u = _urlopen_with_retry(self.FTP_HOST) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 29, in wrappedreturn _retry_thrice(func, exc, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 25, in _retry_thriceraise last_exc File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_urllib2net.py", line 21, in _retry_thricereturn func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 215, in urlopenreturn opener.open(url, data, timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 515, in open response =self._open(req, data) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 532, in _open result =self._call_chain(self.handle_open, protocol, protocol +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 492, in _call_chain result = func(*args) ^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 1582, in ftp_openraise URLError(exp) from exp urllib.error.URLError: <urlopen error 500 OOPS: vsf_sysutil_bind> Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 1572, in ftp_open fp, retrlen = fw.retrfile(file, type) ^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 2450, in retrfileraise URLError(f'ftp error: {reason}') from reason urllib.error.URLError: <urlopen error ftp error: 500 OOPS: vsf_sysutil_bind> Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/urllib/request.py", line 2447, in retrfile conn, retrlen =self.ftp.ntransfercmd(cmd) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/ftplib.py", line 353, in ntransfercmd host, port =self.makepasv() ^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/ftplib.py", line 327, in makepasv untrusted_host, port = parse227(self.sendcmd('PASV')) ^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/ftplib.py", line 281, in sendcmdreturnself.getresp() ^^^^^^^^^^^^^^ File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/ftplib.py", line 254, in getrespraise error_perm(resp) ftplib.error_perm: 500 OOPS: vsf_sysutil_bind

@carljm
Copy link
Member

test_urllib2net just started failing on three buildbots. On two of them it failed on the commit previous to this one (2d370da) and on one it failed on this commit. Given that, and the greater invasiveness of the prior commit, I suspect this commit is not to blame for the failure.

carljm added a commit to carljm/cpython that referenced this pull request Mar 14, 2023
* main: (50 commits) pythongh-102674: Remove _specialization_stats from Lib/opcode.py (python#102685) pythongh-102660: Handle m_copy Specially for the sys and builtins Modules (pythongh-102661) pythongh-102354: change python3 to python in docs examples (python#102696) pythongh-81057: Add a CI Check for New Unsupported C Global Variables (pythongh-102506) pythonGH-94851: check unicode consistency of static strings in debug mode (python#102684) pythongh-100315: clarification to `__slots__` docs. (python#102621) pythonGH-100227: cleanup initialization of global interned dict (python#102682) doc: Remove a duplicate 'versionchanged' in library/asyncio-task (pythongh-102677) pythongh-102013: Add PyUnstable_GC_VisitObjects (python#102014) pythonGH-102670: Use sumprod() to simplify, speed up, and improve accuracy of statistics functions (pythonGH-102649) pythongh-102627: Replace address pointing toward malicious web page (python#102630) pythongh-98831: Use DECREF_INPUTS() more (python#102409) pythongh-101659: Avoid Allocation for Shared Exceptions in the _xxsubinterpreters Module (pythongh-102659) pythongh-101524: Fix the ChannelID tp_name (pythongh-102655) pythongh-102069: Fix `__weakref__` descriptor generation for custom dataclasses (python#102075) pythongh-98169 dataclasses.astuple support DefaultDict (python#98170) pythongh-102650: Remove duplicate include directives from multiple source files (python#102651) pythonGH-100987: Don't cache references to the names and consts array in `_PyEval_EvalFrameDefault`. (python#102640) pythongh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct (python#102562) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102631) ...
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
…urce files (python#102651) Remove duplicate include directives from multiple source files
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
…urce files (python#102651) Remove duplicate include directives from multiple source files
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate #include directives in multiple C files

3 participants

@chgnrdv@carljm@bedevere-bot