Skip to content

gh-102690: Use Edge as fallback in webbrowser instead of IE#102691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merwok merged 9 commits into from
Mar 16, 2023
Merged

gh-102690: Use Edge as fallback in webbrowser instead of IE #102691

merwok merged 9 commits into from
Mar 16, 2023

Conversation

@DBJim
Copy link
Contributor

@DBJimDBJim commented Mar 14, 2023•
edited by bedevere-bot
Loading

@bedevere-bot
Copy link

bedevere-bot commented Mar 14, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-botbedevere-bot mentioned this pull request Mar 14, 2023
Closed
@ghost
Copy link

ghost commented Mar 14, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

bedevere-bot commented Mar 14, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

merwok
merwok requested changes Mar 14, 2023
View reviewed changes
@bedevere-bot

This comment was marked as resolved.

Sign in to view
DBJimand others added 2 commits March 15, 2023 01:38
@DBJim@merwok
Update Lib/webbrowser.py
ecc53fb
Co-authored-by: Éric <merwok@netwok.org>
@DBJim@merwok
Update Misc/NEWS.d/next/Windows/2023-03-14-10-52-43.gh-issue-102690.s…
8a00dec
…bXtqk.rst Co-authored-by: Éric <merwok@netwok.org>
@merwokmerwok requested a review from zoobaMarch 14, 2023 14:49
@merwokmerwok added awaiting core review type-feature A feature request or enhancement 3.12 only security fixes and removed awaiting changes labels Mar 14, 2023
@merwokmerwok changed the title gh-102690: Update webbrowser.py to use Edge as fallback instead of IEgh-102690: Update webbrowser to use Edge as fallback instead of IEMar 14, 2023
zooba
zooba reviewed Mar 14, 2023
View reviewed changes
@DBJimDBJim requested a review from zoobaMarch 15, 2023 06:52
zooba
zooba approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@zoobazooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will let @merwok follow up (and/or hit the merge button)

merwok
merwok reviewed Mar 15, 2023
View reviewed changes
@DBJimDBJim requested a review from merwokMarch 15, 2023 23:52
zooba
zooba reviewed Mar 16, 2023
View reviewed changes
@DBJim@zooba
Update Lib/webbrowser.py
3c42f6d
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@merwokmerwok changed the title gh-102690: Update webbrowser to use Edge as fallback instead of IEgh-102690: Use Edge as fallback in webbrowser instead of IEMar 16, 2023
@merwokmerwok merged commit 1c9f339 into python:mainMar 16, 2023
carljm added a commit to carljm/cpython that referenced this pull request Mar 17, 2023
@carljm
Merge branch 'main' into inlinecomp2
1a8f4a0
* main: (34 commits) pythongh-102701: Fix overflow in dictobject.c (pythonGH-102750) pythonGH-78530: add support for generators in `asyncio.wait` (python#102761) Increase stack reserve size for Windows debug builds to avoid test crashes (pythonGH-102764) pythongh-102755: Add PyErr_DisplayException(exc) (python#102756) Fix outdated note about 'int' rounding or truncating (python#102736) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102760) pythongh-99726: Improves correctness of stat results for Windows, and uses faster API when available (pythonGH-102149) pythongh-102192: remove redundant exception fields from ssl module socket (python#102466) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102743) pythongh-102737: Un-ignore ceval.c in the CI globals check (pythongh-102745) pythonGH-102748: remove legacy support for generator based coroutines from `asyncio.iscoroutine` (python#102749) pythongh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` (python#102722) pythonGH-102653: Make recipe docstring show the correct distribution (python#102742) Add comments to `{typing,_collections_abc}._type_repr` about each other (python#102752) pythongh-102594: PyErr_SetObject adds note to exception raised on normalization error (python#102675) pythongh-94440: Fix issue of ProcessPoolExecutor shutdown hanging (python#94468) pythonGH-100112: avoid using iterable coroutines in asyncio internally (python#100128) pythongh-102690: Use Edge as fallback in webbrowser instead of IE (python#102691) pythongh-102660: Fix Refleaks in import.c (python#102744) pythongh-102738: remove from cases generator the code related to register instructions (python#102739) ...
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@DBJim@Fidget-Spinner
pythongh-102690: Use Edge as fallback in webbrowser instead of IE (py…
b05f294
…thon#102691)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@DBJim@warsaw
pythongh-102690: Use Edge as fallback in webbrowser instead of IE (py…
ab8f1d8
…thon#102691)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zoobazoobazooba approved these changes

@merwokmerwokAwaiting requested review from merwok

Assignees

No one assigned

Labels

3.12only security fixesOS-windowstype-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DBJim@bedevere-bot@merwok@zooba@AlexWaygood