Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
[3.11] gh-102721: Improve coverage of _collections_abc._CallableGenericAlias#102788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
sobolevn commented Mar 17, 2023 • edited by miss-islington
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by miss-islington
Uh oh!
There was an error while loading. Please reload this page.
AlexWaygood left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is missing the test_type_subst_errors method you added here: https://github.com/python/cpython/pull/102722/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305dR1972-R1981
Is that deliberate?
sobolevn commented Mar 17, 2023
No, it is not. I've missed it during the backport process. |
AlexWaygood left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
miss-islington commented Mar 17, 2023
Status check is done, and it's a success ✅. |
bedevere-bot commented Mar 17, 2023
|
bedevere-bot commented Mar 17, 2023
|
bedevere-bot commented Mar 17, 2023
|
bedevere-bot commented Mar 17, 2023
|
This is a backport of #102722 without the
typing.pychanges._collections_abc._CallableGenericAlias#102721Automerge-Triggered-By: GH:AlexWaygood