Skip to content

Conversation

@davidak
Copy link
Contributor

@davidakdavidak commented Nov 1, 2018

This also makes it consistent with other places like:

This also makes it consistent with other places like: - https://docs.python.org/dev/copyright.html - https://www.python.org/ footer - https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Python/getcopyright.c#L7 This is my first contribution to python, completely done using GitHubs webinterface. I will sign the CLA later today.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@matrixise
Copy link
Member

For me, it's ok, we have some references where the copyright by the PSF is from 2001-2018. We could merge it after the review of @VanL .

@VanL
Copy link
Member

VanL commented Nov 7, 2018

This is fine with me.

VanL
VanL approved these changes Nov 8, 2018
@Mariatta
Copy link
Member

I beleieve there is an issue in bpo about the copyright. I'll have to look it up and link it here.

@ned-deily
Copy link
Member

@Mariatta, Are you thinking of https://bugs.python.org/issue29555 ? That also covers copyright dates in a number of modules.

@Mariatta
Copy link
Member

Ah yeah that's the issue I was thinking.

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mariatta
Copy link
Member

Thanks @davidak and congrats on your first contribution to CPython 🌮

@davidakdavidak deleted the patch-1 branch November 10, 2018 16:25
Stevoisiak added a commit to Stevoisiak/cpython that referenced this pull request Feb 8, 2023
Uses a range of years for the copyright in LICENSE file. Follows up on python#10287 and makes it consistent with other copyright notices).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@davidak@the-knights-who-say-ni@matrixise@VanL@Mariatta@ned-deily@gvanrossum@bedevere-bot@miss-islington