Skip to content

gh-84436: Make Interned Strings Immortal#102887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ericsnowcurrently wants to merge 19 commits into
base:main
Choose a base branch
from
Draft

gh-84436: Make Interned Strings Immortal #102887

ericsnowcurrently wants to merge 19 commits into from

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commented Mar 21, 2023•
edited
Loading

This is a prerequisite for a per-interpreter GIL if the interned strings dict stays global (e.g. gh-102858).

(This is based on gh-102925. It also requires gh-19474.)

@bedevere-botbedevere-bot mentioned this pull request Mar 21, 2023
Closed
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Mar 21, 2023
Closed
@ericsnowcurrently
Copy link
MemberAuthor

ericsnowcurrently commented Mar 21, 2023

CC @kumaraditya303

@ericsnowcurrently
Factor out add_threadstate().
546b934
@ericsnowcurrently
Add _PyThreadState_InitDetached().
0bcd136
@ericsnowcurrently
Add _PyThreadState_ClearDetached().
35d5310
@ericsnowcurrently
Add _PyRuntime.cached_objects.main_tstate.
cba9e34
@ericsnowcurrently
Add _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsState().
3b1bb8b
@ericsnowcurrently
Add _Py_AddToGlobalDict().
eb42aa1
@ericsnowcurrently
Drop _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsStat…
4e9da2d
…e().
@ericsnowcurrently
Add acquire_global_objects_lock() and release_global_objects_lock().
6216207
@ericsnowcurrently
Add some TODO comments.
3c007c0
@ericsnowcurrently
Factor out store_interned().
7d95514
@ericsnowcurrently
Store a thread state to use just for interned strings.
5c20b84
@ericsnowcurrently
Always use the main interpreter when possibly resizing the interned d…
a3ae02a
…ict.
@ericsnowcurrently
Use _PyRuntime.cached_objects.main_tstate instead.
d5fbc37
@ericsnowcurrently
Add _PyThreadState_IsBound() and _PyThreadState_Unbind().
459325f
@ericsnowcurrently
Make sure the one-off tstate is bound before using it.
4f25244
@ericsnowcurrently
Use _Py_AcquireGlobalObjectsState() in store_interned().
e68535a
@ericsnowcurrently
Use _Py_AddToGlobalDict().
22753b3
@ericsnowcurrentlyericsnowcurrentlyforce-pushed the immortal-interned-strings branch from 13f3b8f to ca776b1CompareMarch 22, 2023 18:25
@ericsnowcurrentlyericsnowcurrentlyforce-pushed the immortal-interned-strings branch from ca776b1 to 9b0dc99CompareMarch 22, 2023 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensityZeroIntensity will be requested when the pull request is marked ready for reviewZeroIntensity is a code owner

Assignees

No one assigned

Labels

awaiting core reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericsnowcurrently@bedevere-bot