GH-93533: Shrink the LOAD_ATTR caches#103014
Closed
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a fixed array of cached methods to the
PyTypeObjectstruct. This approach saves memory if there are ~23x moreLOAD_ATTRsites than there are types.A size of 16 was chosen because:
LOAD_ATTRhit rate onpyperformance, with 32.5% of specialization failures due to a too-small cache.LOAD_ATTRhit rate onpyperformance, with 8.7% of specialization failures due to a too-small cache.LOAD_ATTRhit rate onpyperformance, with 3.3% of specialization failures due to a too-small cache.A flexible buffer was also considered, but that was 1% slower, likely due to the additional indirection and management of the buffer.
LOAD_ATTRis too large. #93533