gh-103053: Skip the whole test_freeze module in tests on s390x with PGO

[sobolevn]

Now, let's try the buildbot test with these changes.

• Issue: test_tools: test_freeze_simple_script() times out after 15 min: --with-lto --enable-optimizations (s390x LTO buildbots) #103053

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 74ded76 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit ee8f33c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 9b2a4c3 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit be3e15d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[sobolevn]

@zware can you please take a look when you have the time?

[vstinner]

Please don't do that. It's ok to have a red buildbot, it doesn't prevent to release Python: it's only part of PEP 11 Tier 3.

Failures on these platforms do not block a release.

If you skip the failing test, as the maintainer of this platform, I will no be able to notice it :-(

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[sobolevn]

So, other options are:

1. Increase the test timeout for this platform (maybe only for pgo builds)
2. Try optimizing freeze process (can be very complex and error prone)
3. Create another form of testing 🤔

Any ideas are welcome!

[ambv]

We can try with a greatly increased timeout for this particular platform and see if that's indeed the problem.

[encukou]

Any ideas are welcome!

Use a subdirectory in the build area, instead of os_helper.temp_dir(), and guard against it being copied into itself recursively?

[vstinner]

Create another form of testing thinking

Honestly, I'm not convinced by the value of this test. If freeze is badly broken, everybody will notice since Python itself is also frozen, no? Or did I misunderstood the purpose of the test, or what's frozen exactly? Don't all core devs already indirectly test frozen Python?

[vstinner]

Please don't do that. It's ok to have a red buildbot, it doesn't prevent to release Python: it's only part of PEP 11 Tier 3.
If you skip the failing test, as the maintainer of this platform, I will no be able to notice it :-(

I wrote PR #109591 to not skip the test on s390x, but only if Python is built with PGO, which is differerent.