GH-82565: Fixed a possible assertion error#103206
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixed a possible assertion error
bedevere-bot commented Apr 3, 2023
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
All commit authors signed the Contributor License Agreement. |
SahillMulani changed the title 
Eclips4 reviewed Apr 3, 2023
| (void)_PyObject_LookupAttr(file, &_Py_ID(read), &self->read); | ||
| (void)_PyObject_LookupAttr(file, &_Py_ID(readline), &self->readline); | ||
| if (!self->readline|| !self->read) { | ||
| if (_PyObject_LookupAttrId(file, &PyId_read, &self->read) <= 0|| |
Member
There was a problem hiding this comment.
Seems that you forgot to define a PyId_read and PyId_readline.
However, have you try to a built python with this patch manually?
Author
There was a problem hiding this comment.
I have fixed this issue in the latest commit ✅
Please have a look , Thanks
Member
There was a problem hiding this comment.
Seems that tests keep falling.
You sure that you made necessary changes?
Author
There was a problem hiding this comment.
Below changes are made by me :
All other changes are imported as it is from #16606
Therefore, I am not sure where exactly the code is failing .
Member
Eclips4 commented Apr 4, 2023
Hi! You forgot to define some identifiers, so, CI/CD fails. |
Author
SahillMulani commented Apr 5, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-82565 Fixed a possible assertion error
[bpo-38384-pickle-assert] #16606
Please check the below code test cases
File without read and readline
File with bad read and without readline
File with bad readline and without read