Skip to content

gh-103092: Isolate msvcrt#103248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 9 commits into from
Apr 12, 2023
Merged

gh-103092: Isolate msvcrt #103248

erlend-aasland merged 9 commits into from
Apr 12, 2023

Conversation

@aisk
Copy link
Contributor

@aiskaisk commented Apr 4, 2023•
edited by bedevere-bot
Loading

@aiskaisk requested a review from a team as a code ownerApril 4, 2023 16:07
@bedevere-botbedevere-bot mentioned this pull request Apr 4, 2023
Closed
25 tasks
arhadthedev
arhadthedev reviewed Apr 5, 2023
View reviewed changes
@aisk@arhadthedev
Update PC/msvcrtmodule.c
bc8aa95
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
@erlend-aaslanderlend-aasland self-requested a review April 8, 2023 19:48
erlend-aasland
erlend-aasland reviewed Apr 8, 2023
View reviewed changes
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Apr 8, 2023•
edited
Loading

I'd like to land these first:

@erlend-aaslanderlend-aasland changed the title gh-103092: isolate msvcrtgh-103092: Isolate msvcrtApr 8, 2023
aiskand others added 5 commits April 9, 2023 13:05
@aisk@erlend-aasland
Update Misc/NEWS.d/next/Library/2023-04-04-21-44-25.gh-issue-103092.D…
8dd469f
…z0_Xn.rst Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@aisk@erlend-aasland
Update PC/msvcrtmodule.c
cdc37b7
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@aisk@erlend-aasland
Update PC/msvcrtmodule.c
6119c5b
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@aisk
fix error branch in exec_module
b3f5edb
@erlend-aasland
Merge branch 'main' into isolate-msvcrt
cb96632
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@erlend-aaslanderlend-aasland merged commit dce2d38 into python:mainApr 12, 2023
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Apr 12, 2023

Thanks, @aisk.

@aiskaisk deleted the isolate-msvcrt branch April 12, 2023 11:54
aisk added a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@aisk
pythongh-103092: Isolate msvcrt (python#103248)
21ceaf5
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedevarhadthedevarhadthedev left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aisk@erlend-aasland@arhadthedev@bedevere-bot