gh-102799: use sys.exception() instead of sys.exc_info() in tests#103293
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iritkatriel requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and vsajip as code owners
gvanrossum approved these changes Apr 6, 2023
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
One nit, no need to wait for another approval after you fix it.
Lib/test/test_asyncio/test_tasks.py Outdated
| timed_out | ||
| andtask.uncancel() ==0 | ||
| andsys.exc_info()[0] isasyncio.CancelledError | ||
| andisinstance(sys.exception(), asyncio.CancelledError) |
Member
There was a problem hiding this comment.
Why add the isinstance() call? The original test insists that you get exactlyCancelledError. I think that's useful to test for, since not all cancellation code is resilient to subclasses of CancelledError.
(In other cases below I don't mind.)
iritkatriel commented Apr 6, 2023
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that 3.10 is no longer getting bugfixes, we can use sys.exception() without worrying about it impacting bugfix backports (it exists since 3.11).
This PR does the tests.