Skip to content

[3.11] GH-102700: allow built-in modules to be submodules (GH-103162)#103322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 1 commit into from
Apr 6, 2023
Merged

[3.11] GH-102700: allow built-in modules to be submodules (GH-103162) #103322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Lib/importlib/_bootstrap.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -747,8 +747,6 @@ def module_repr(module):

@classmethod
def find_spec(cls, fullname, path=None, target=None):
if path is not None:
return None
if _imp.is_builtin(fullname):
return spec_from_loader(fullname, cls, origin=cls._ORIGIN)
else:
Expand Down
17 changes: 0 additions & 17 deletions Lib/test/test_importlib/builtin/test_finder.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,13 +37,6 @@ def test_failure(self):
spec=self.machinery.BuiltinImporter.find_spec(name)
self.assertIsNone(spec)

deftest_ignore_path(self):
# The value for 'path' should always trigger a failed import.
withutil.uncache(util.BUILTINS.good_name):
spec=self.machinery.BuiltinImporter.find_spec(util.BUILTINS.good_name,
['pkg'])
self.assertIsNone(spec)


(Frozen_FindSpecTests,
Source_FindSpecTests
Expand DownExpand Up@@ -77,16 +70,6 @@ def test_failure(self):
loader=self.machinery.BuiltinImporter.find_module('importlib')
self.assertIsNone(loader)

deftest_ignore_path(self):
# The value for 'path' should always trigger a failed import.
withutil.uncache(util.BUILTINS.good_name):
withwarnings.catch_warnings():
warnings.simplefilter("ignore", DeprecationWarning)
loader=self.machinery.BuiltinImporter.find_module(
util.BUILTINS.good_name,
['pkg'])
self.assertIsNone(loader)


(Frozen_FinderTests,
Source_FinderTests
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-04-01-00-46-31.gh-issue-102700.493NB4.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
Allow built-in modules to be submodules. This allows submodules to be statically linked into a CPython binary.