gh-83004: Harden winreg init#103386
Merged
gh-83004: Harden winreg init #103386
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
erlend-aaslandforce-pushed the cleanup-winreg branch from 2c298f2 to e664a52Compare
ContributorAuthor
erlend-aasland commented Apr 10, 2023
@zooba, I'm landing this later tonight. |
aisk reviewed Apr 11, 2023
| ADD_INT(REG_FULL_RESOURCE_DESCRIPTOR); | ||
| ADD_INT(REG_RESOURCE_REQUIREMENTS_LIST); | ||
| #undef ADD_INT |
Contributor
There was a problem hiding this comment.
Should we undef the ADD_KEY here also?
ContributorAuthor
There was a problem hiding this comment.
Yes ideally, but not worth a separate PR, IMO.
Contributor
There was a problem hiding this comment.
Trying to merge this to #103250 , I'll add it is this PR.
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.