gh-103180: Add CI timeouts to all GitHub Actions jobs#103437
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sobolevn changed the title 
hugovk approved these changes Apr 11, 2023
Member
hugovk left a comment
hugovk left a comment There was a problem hiding this comment.
Thanks for the analysis at #103180 (comment).
We could probably skip timeouts for the short ones: timeouts tend to occur in the more complex and therefore slower ones, but I'm also fine adding them just in case.
This comment was marked as spam.
This comment was marked as spam.
MemberAuthor
sobolevn commented Apr 11, 2023
@Ismaelkadir sorry, I don't understand your message :( |
This comment was marked as spam.
This comment was marked as spam.
hauntsaninja approved these changes Apr 14, 2023
Contributor
hauntsaninja left a comment
hauntsaninja left a comment There was a problem hiding this comment.
Thanks for doing this!
Contributor
miss-islington commented Apr 14, 2023
Contributor
miss-islington commented Apr 14, 2023
Sorry, @sobolevn and @hugovk, I could not cleanly backport this to |
MemberAuthor
sobolevn commented Apr 14, 2023
Do you want me to backport this to 3.11 as well? |
Member
hugovk commented Apr 14, 2023
Yes please, could be useful there too :) |
carljm added a commit to carljm/cpython that referenced this pull request Apr 14, 2023
* main: pythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535) pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437) Remove double space in import error message (python#103458) ipaddress: Remove non-existent ip_str param from docstring (python#103461) Fix syntax typo in isolating extensions doc (python#103516) pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407) Proofread howto/perf_profiling.rst (python#103530) Fix unused functions warnings in instrumentation.c (pythonGH-103515)
sobolevn added a commit to sobolevn/cpython that referenced this pull request Apr 14, 2023
…ythonGH-103437). (cherry picked from commit be8903e) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
bedevere-bot commented Apr 14, 2023
GH-103543 is a backport of this pull request to the 3.11 branch. |
carljm added a commit to carljm/cpython that referenced this pull request Apr 14, 2023
* superopt: fix incompatible types update generated cases don't unnecessarily re-find args in error case Apply suggestions from code review pythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535) pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437) Remove double space in import error message (python#103458) ipaddress: Remove non-existent ip_str param from docstring (python#103461) Fix syntax typo in isolating extensions doc (python#103516) pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407) Proofread howto/perf_profiling.rst (python#103530) Fix unused functions warnings in instrumentation.c (pythonGH-103515)
hugovk pushed a commit that referenced this pull request Apr 15, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #103180 (comment) on why I used the numbers I used.
Docs: https://docs.github.com/ru/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes