Skip to content

GH-103082: Code cleanup from review.#103474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 2 commits into from
Apr 29, 2023
Merged

GH-103082: Code cleanup from review. #103474

JelleZijlstra merged 2 commits into from
Apr 29, 2023

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Apr 12, 2023•
edited by bedevere-bot
Loading

@markshannonmarkshannon changed the title Code cleanupGH-103082: Code cleanup from review.Apr 12, 2023
@bedevere-botbedevere-bot mentioned this pull request Apr 12, 2023
Closed
4 tasks
@markshannonmarkshannon marked this pull request as ready for review April 12, 2023 13:07
Fidget-Spinner
Fidget-Spinner reviewed Apr 12, 2023
View reviewed changes
erlend-aasland
erlend-aasland reviewed Apr 13, 2023
View reviewed changes
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Apr 29, 2023

I'm not sure why I can't merge this, maybe @Fidget-Spinner has to approve explicitly?

@JelleZijlstraJelleZijlstra enabled auto-merge (squash) April 29, 2023 03:35
auto-merge was automatically disabled April 29, 2023 04:23

Pull request was closed

@JelleZijlstraJelleZijlstra enabled auto-merge (squash) April 29, 2023 04:24
@JelleZijlstraJelleZijlstra merged commit 738c226 into python:mainApr 29, 2023
@markshannonmarkshannon deleted the pep-669-review branch September 26, 2023 12:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markshannon@JelleZijlstra@erlend-aasland@Fidget-Spinner@bedevere-bot