Skip to content

Conversation

@art049
Copy link
Contributor

@art049art049 commented Apr 20, 2023

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Apr 20, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@art049art049force-pushed the fix/perf-maps-format branch from 6cb2f11 to 8af8b2bCompareApril 20, 2023 16:15
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@art049art049force-pushed the fix/perf-maps-format branch from ddc2b2d to 5df35f0CompareApril 20, 2023 16:25
@arhadthedevarhadthedev added interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.11 only security fixes 3.12 only security fixes labels Apr 20, 2023
@art049art049force-pushed the fix/perf-maps-format branch from db8707f to 4e43459CompareApril 20, 2023 17:14
@art049art049force-pushed the fix/perf-maps-format branch from 4e43459 to 0ba49e2CompareApril 20, 2023 17:55
@terryjreedy
Copy link
Member

I think that this should wait until Pablo verifies that it is indeed the implementation that should be changed.

@carljm
Copy link
Member

@art049 did you verify that the new output after this PR works the same with perf?

@terryjreedy since the relevant docs here are the external perf map specification, not the CPython docs, it seems clear that the implementation in CPython should match the specification. There is no option to change the specification, we don't own it.

@art049
Copy link
ContributorAuthor

@art049 did you verify that the new output after this PR works the same with perf?

Yes, also there are existing tests checking this:

deftest_python_calls_appear_in_the_stack_if_perf_activated(self):
withtemp_dir() asscript_dir:
code="""if 1:
def foo(n):
x = 0
for i in range(n):
x += i
def bar(n):
foo(n)
def baz(n):
bar(n)
baz(10000000)
"""
script=make_script(script_dir, "perftest", code)
stdout, stderr=run_perf(script_dir, sys.executable, "-Xperf", script)
self.assertEqual(stderr, "")
self.assertIn(f"py::foo:{script}", stdout)
self.assertIn(f"py::bar:{script}", stdout)
self.assertIn(f"py::baz:{script}", stdout)

@pablogsalpablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 7, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 0ba49e2 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 7, 2023
@pablogsal
Copy link
Member

Running this PR with the buildbots as the perf stuff is not checked on regular CI.

jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 9, 2023
* main: (47 commits) pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188) pythonGH-104308: socket.getnameinfo should release the GIL (python#104307) pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311) pythongh-99113: A Per-Interpreter GIL! (pythongh-104210) pythonGH-104284: Fix documentation gettext build (python#104296) pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251) pythongh-104223: Fix issues with inheriting from buffer classes (python#104227) pythongh-99108: fix typo in Modules/Setup (python#104293) pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172) pythongh-103193: Improve `getattr_static` test coverage (python#104286) Trim trailing whitespace and test on CI (python#104275) pythongh-102500: Remove mention of bytes shorthand (python#104281) pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256) pythongh-99108: Replace SHA3 implementation HACL* version (python#103597) pythongh-104273: Remove redundant len() calls in argparse function (python#104274) pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200) pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266) pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244) pythongh-103650: Fix perf maps address format (python#103651) pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243) ...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.11only security fixes3.12only security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@art049@bedevere-bot@terryjreedy@carljm@pablogsal@sunmy2019@arhadthedev